Re: CVS commit: src/sys/ufs/lfs

[YAMAMOTO Takashi <yamt%mwd.biglobe.ne.jp@localhost>]

> >>Module Name:        src
> >>Committed By:       rtr
> >>Date:               Sun Mar 19 04:10:03 UTC 2006
> >>
> >>Modified Files:
> >>    src/sys/ufs/lfs: lfs_syscalls.c
> >>
> >>Log Message:
> >>init struct vnode *vp = NULL
> >>coverity 2724 / run 6
> >>XXX in future runs coverity may complain about deref NULL now but comment
> >>    on line 382 indicates this should not be possible
> >>    
> >>
> >
> >is it a real fix, or just to appease coverity?
> >  
> >
> It is a real fix.  The XXX is just an indicator that coverity will 
> probably complain about
> NULL deref now which could be avoided but then that would only be for 
> the purpose of appeasing coverity.

basically, vp is used only when v_daddr != LFS_UNUSED_DADDR.
the only exception i can think of is LFS_FORCE_WRITE.
("Don't force-write the ifile" case)  while it seems like a bug,
i don't think vp = NULL fixes it.

can you explain what problem your change fixed?

YAMAMOTO Takashi