Re: CVS commit: src/usr.sbin/ndiscvt

["Alan Ritter" <ritter.alan%gmail.com@localhost>]

On 3/30/06, Daniel Carosone <dan%geek.com.au@localhost> wrote:
> On Thu, Mar 30, 2006 at 03:33:02PM -0800, Alan Ritter wrote:
> > There is a lot more revision history in my NDIS repository on
> > Sourceforge, but I was thinking it was sufficent to do 3 commits:
> > 1. The original FreeBSD code (done)
> > 2. Patches contributed from others before the start of SoC (done)
> > 3. My code at the end of SoC (I was about to do this)
>
> That's fine[*], just don't be frigtened of describing this and what
> you're doing in more detail in the commit message.

Ok, thanks I'll try to be more descriptive from now on.

> [*] #1 should also have been a cvs import, with reference to the other
> repository, but that's water under the bridge at this point.

Yes I was considering using vendor branch, but thought it wouldn't
really help because importing large batches of changes from FreeBSD
would destabilize the code too much and make it harder to maintain. 
My thinking was that it would be better to review, incorporate and
test the changes one at a time.  I also had a short conversation with
Jason Thorpe, and he said  most drivers from other BSDs aren't done as
vendor branches because there are too many differences.

On the other hand, if there's a very compelling reason to use a vendor
branch, I could remove those files, and do the import.

Thanks!