Re: CVS commit: src/sys/dev/pcmcia

[Rui Paulo <rpaulo%fnop.net@localhost>]

Masao Uebayashi <uebayasi%brains.co.jp@localhost> writes:

>> Log Message:
>> In pcmcia_parse_cis_tuple(), refactor the memspace section introducing
>> a switch statement and fixing CID 566.
>
> * What was the real error of this CID?

DEADCODE: "cfe->num_memspace = 0; is never called because
PCMCIA_TPCE_FS_MEMSPACE_NONE == 0"

> * Personally, I like to separate whitespace / indent changes for cvs
>   diff readability.

When I changed the if clauses to a switch I had to indent back. I
think this is appropriate to do in the same commit.

> (Other than those, I like this change. :-)

I guess you were the only one..

-- 
  Rui Paulo                     <rpaulo@{NetBSD{,-PT}.org,fnop.net}>