Re: CVS commit: src/sys/dev/usb

[Jukka Salmi <j+nbsd%2006.salmi.ch@localhost>]

Arnaud Lacombe --> source-changes (2006-06-11 02:01:51 +0200):
> On Sun, Jun 04, 2006 at 07:34:16PM +0000, Christos Zoulas wrote:
> > 
> > Module Name:        src
> > Committed By:       christos
> > Date:               Sun Jun  4 19:34:16 UTC 2006
> > 
> > Modified Files:
> >     src/sys/dev/usb: usb_subr.c
> > 
> > Log Message:
> > Don't allocate 1K on the stack.
> > 
> > 
> > To generate a diff of this commit:
> > cvs rdiff -r1.131 -r1.132 src/sys/dev/usb/usb_subr.c
> > 
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> This changes produce a panic when unplugging an usb<->ide adapter (it
> happens also with 1.133 and 1.334):
> 
> kernel; supervisor trap page fault, code=0
> Stopped in pid 4.1 (usb0) netbsd:kprintf+0x82b: repne scasb (%esi)
> db> bt
> kprintf()
> print()
> usb_disconnect_port()
> uhub_explore()
> 
> If I back out to 1.131 everything works fine again.

A 3.99.20 kernel with usb_subr.c 1.133 just paniced while detaching a
USB CF device:

uvm_fault(0xc043f220, 0, 1) -> 0xe
kernel: supervisor trap page fault, code=0
Stopped in pid 6.1 (usb3) at    netbsd:config_detach+0x18:      movl    
0x1c(%ebx),%eax
db> config_detach(c14f8320,1,c17ebe9c,c1ad2d00,c17ebf80) at 
netbsd:config_detach+0x18
usb_disconnect_port(c17b5648,c17ebe80,10,0,cb1adc98) at 
netbsd:usb_disconnect_port+0x9c
uhub_explore(c17ebf80,0,cbb8cc6c,c0362cd8,cb1adc98) at netbsd:uhub_explore+0x21d
usb_discover(c156a000,1f4,0,c01004d1,cb1adc60) at netbsd:usb_discover+0x36
usb_event_thread(c156a000,4b0000,4b7000,0,c01002e6) at netbsd:us

I could try usb_subr.c 1.131 if this helps...


Regards, Jukka

-- 
bashian roulette:
$ ((RANDOM%6)) || rm -rf ~