Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: [gdamore-uart] src/sys/arch/m68k/fpsp



In article <4497F783.6000302%tadpole.com@localhost>,
Garrett D'Amore  <garrett_damore%tadpole.com@localhost> wrote:
>Izumi Tsutsui wrote:
>> garrett_damore%tadpole.com@localhost wrote:
>>
>>   
>>> Looks fine to me, though I'd have used
>>>
>>> ${SED:=sed}
>>>
>>> instead.
>>>     
>>
>> Is it okay to commit this?
>>   
>
>Why ${TOOL_SED:Q}  instead of ${TOOL_SED}?
>
>On Solaris at least, the construct ${TOOL_SED:Q} generates a "bad
>substitution" error.

But that is a bmake expansion. Are you sure your bmake is up-to-spec?

christos




Home | Main Index | Thread Index | Old Index