Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ic



"Jared D. McNeill" wrote:

> Module Name:  src
> Committed By: jmcneill
> Date:         Tue Jun 20 15:35:11 UTC 2006
> 
> Modified Files:
> 
>       src/sys/dev/ic: spic.c spicvar.h
> 
> Log Message:
> 
> Hook the lid switch, sleep button, and hibernate button into sysmon. This
> enables special Fn keys on Sony Vaio laptops.

There's lots of magic numbers in there.  For example:

+       if (v2 == 0x30) {
+               case 0x50:      /* opened */
+               case 0x51:      /* closed */
+       if (v2 == 0x20) {
+               case 0x10:      /* suspend */
+               case 0x1c:      /* hibernate */


Should we have a spicreg.h with some of these described a bit more
fully?

Simon.



Home | Main Index | Thread Index | Old Index