Re: CVS commit: src/sys/kern

["Perry E. Metzger" <perry%piermont.com@localhost>]

Garrett D'Amore <garrett_damore%tadpole.com@localhost> writes:
>> Two days is probably too little. One routinely gets situations where
>> machines get confused and file system time exceeds RTC time by quite a
>> bit.
>>
>> On the x86 port, we used to use a much larger margin -- years in
>> fact. That might be excessive, but two days is too small.
>
> This was discussed with others last night, including Christos and
> Gendalia.  The x86 margin was 5 years.  I changed it to use the same 2
> days the other ports use.  The 2 days is just a warning.  If the
> filesystem time is more than two days out of date, then you probably
> haven't been keeping your clock updated (you might have been running
> another OS?), and the warning to check your clock is still advisable. 
> It doesn't actually _do_ anything, unless the clock gets more than two
> days _behind_ your filesystem.
>
> If the clock is more than two days _behind_, then your system clock is
> probably busted, and we take corrective action by trusting the
> filesystem time.  (Time should always move _forward_, not backwards.)
>
> I recognize these are policy decisions, and I'm happy to adjust.  I'd
> _prefer_ to have a single policy that works for all of our ports rather
> than different policies for different ports, though.

Oh, I agree that one policy is absolutely the correct thing.

> I definitely think 5 years is _excessive_.  I'd complain if the
> difference was more than 6 months.

That seems like a fine compromise.

Perry