Re: CVS commit: src

[Brett Lymn <blymn%baesystems.com.au@localhost>]

On Wed, Sep 06, 2006 at 11:35:50PM +0900, YAMAMOTO Takashi wrote:
> 
> - please use vfs_composefh_free rather than kmem_free.

Ah, thanks :)

> - comparing FHANDLE_SIZE is not the same as comparing fid_len
>   because FHANDLE_SIZE is padded.

I know but FHANDLE_SIZE is broken it seems :( when I tried using it I
was getting kernel panics on illegal memory access.  It seems that
some of the vhtofp calls are not allocating the appropriate amount of
memory.  See my post on this in tech-kern@

> - you seem leaking "th" in some cases.

Will fix.

> - tab vs space problems?
> 

Hmmm.  I will check but that is hard for me to do because my emacs set
up should automatically do the right thing.

-- 
Brett Lymn