Re: CVS commit: src/sys/dev/ic

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

christianbiere%gmx.de@localhost wrote:

> Don't you need at least __attribute__((__packed__)) for struct rtk_desc too?

Maybe it might be needed on machines which have 8 byte alignment
restriction but currently I don't think there is such restriction
even on 64 bit machines.

>  0: uint32_t rtk_cmdstat
>  4: pad1
>  8: uint32_t rtk_vlanctl
> 12: pad2
> 16: uint32_t rtk_bufaddr_lo
> 20: pad3
> 24: uint32_t rtk_bufaddr_hi
> 28: pad4

The offsets of descriptor members are specified by hardware design
of bus-master, so you can't pad it.
---
Izumi Tsutsui