Re: CVS commit: src/sys/dev/pci

["Perry E. Metzger" <perry%piermont.com@localhost>]

Izumi Tsutsui <tsutsui%netbsd.org@localhost> writes:
> Modified Files:
>       src/sys/dev/pci: if_re_pci.c
>
> Log Message:
> Pull another 8139C+ fix from FreeBSD if_re.c rev 1.68:
> Perform hardware diagnostic only on the original RTL8169,
> which was the only device that really needed it.
> (i.e. a possible hardware bug when the NIC was put on a 64bit PCI slot)
>
> Tested with on-board 8139C+ by Brian A. Seklecki.
>
> Note this change might also fix PR kern/34952
> (because re_diag() is no longer called on 8169S/8110S),
> but I'm not sure if the re(4) chip was properly initialized in such case.

Sort of. Presumably I will no longer see the diagnostic fail, but the
diagnostic could only have failed if some other problem was in place
-- presumably some sort of bad initialization. I am not sure if
removing the diagnostic will cause me to have no problems, or if it
will just unmask another problem. Tests may be difficult -- I only get
the failure about one in every 5 to 10 reboots.

Perry