Re: CVS commit: src/sys

[David Young <dyoung%pobox.com@localhost>]

On Thu, Nov 16, 2006 at 03:45:49PM -0800, Tom Spindler wrote:
> 
> The "superfluous curly braces" removal bothers me a bit - in particular,
> in ip_gre.c,
> 
> -       } else {
> +       } else  
>                 IF_ENQUEUE(ifq, m);
> -       }
> 
> Macros have a nasty habit of sometimes becoming multiple statements.
> (Admittedly, in this case, since it's a do { ... } while (0), presumably
> that behavior wouldn't ever happen.)

I noticed a lot of RTFREE()s are preceeded by remarks like that.  A lot
more macros should become inline subroutines, IMO.  I converted RTFREE().

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933