Re: CVS commit: src/sys/dev/scsipi

[Steve Woodford <scw%netbsd.org@localhost>]

On Saturday 25 November 2006 12:24, David Laight wrote:
> On Sat, Nov 25, 2006 at 12:03:39PM +0000, Steve Woodford wrote:
> > - bounds_check_with_label() has been fixed, so put the correct
> > partition size in the default disklabel.
>
> What are the units of the 'correct partition size' ?

Partitions are described in terms of the disk's physical sector size.

> Note that in order to make media with 2k sectors bootable on (eg
> i386), the NetBSD disklabel will have to reside at offset 512 in
> sector zero.

My changes will not have altered the behaviour in the DEV_BSIZE case. The 
only non-512 byte media (apart from CD-ROM) I have here is a USB Flash 
stick/MP3 player. I'd rather not try to boot from it right now.

At least now that there's only one copy of bounds_check_with_label() 
it'll be easier to deal with the problem later on.

Cheers, Steve