Re: CVS commit: src/usr.bin/make

[christos%astron.com@localhost (Christos Zoulas)]

In article <20061220210325.GI1407%snowdrop.l8s.co.uk@localhost>,
David Laight  <david%l8s.co.uk@localhost> wrote:
>On Mon, Dec 18, 2006 at 03:06:16PM +0000, Christos Zoulas wrote:
>> 
>> Module Name: src
>> Committed By:        christos
>> Date:                Mon Dec 18 15:06:16 UTC 2006
>> 
>> Modified Files:
>>      src/usr.bin/make: make.c parse.c targ.c
>> 
>> Log Message:
>> >From Anon Ymous:
>...
>> Flagged a few parameters __unused so this will compile with -Wextra now.
>Aren't we using -Wno-unused-parameter ?
>so those changes aren't needed.

Well, we did that for the kernel, which just had too many of them and it
got to be annoying. Userland, at least from what I've seen so far, needs
a lot less __unused, and does not build with different #ifdef blocks like
the kernel does, so I think it is a good thing to annotate the source this
way.

>Also, since make is built as a host tool, does anything define away __unused ?

I think the compat header already does.

christos