Re: CVS commit: src/sys

[David Laight <david%l8s.co.uk@localhost>]

On Fri, May 04, 2007 at 12:00:34AM +0000, Tom Spindler wrote:
> > Module Name:        src
> > Committed By:       dyoung
> > Date:               Wed May  2 20:40:29 UTC 2007
> > 
> > Modified Files:
> [...]
> >     src/sys/netiso: clnp.h clnp_er.c clnp_frag.c clnp_output.c clnp_raw.c
> >         clnp_subr.c eonvar.h if_eon.c iso.c iso.h iso_pcb.c iso_pcb.h
> >         iso_proto.c iso_var.h tp_iso.c
> 
> As noted on current-users, this inline code breaks ipf on 64-bit 
> architectures,
> due to src/sys/dist/ipf/netinet/ip_fil.h:
> #define      offsetof(t,m)   (int)((&((t *)0L)->m))
> 
> As also pointed out on current-users, either #include'ing <stddef.h>,
> fixing the #define, or making the sockaddr_iso_init1 sub (as defined
> in sys/netiso/iso.h) non-inlined would all probably suffice to make
> things work again.

How big are these inlined lumps of code?
If non-trivial they probably don't want inlining anyway.

        David

-- 
David Laight: david%l8s.co.uk@localhost