Re: CVS commit: src/sys/miscfs/procfs

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Wed, May 30, 2007 at 06:52:45PM +0100, David Laight wrote:
> On Sat, May 26, 2007 at 04:21:04PM +0000, Alistair G. Crooks wrote:
> > Use vm sizes from vmspace, rather than rusage structs, for the same
> > reasons as mentioned previously - see the comment in
> > kvm_proc.c::kvm_getproc2() about rusage values and zombie processes.
> 
> Which is probably out of date after some recent garbage collection I did.
> After the newlock2 merge the lifetimes of some of the structures changed.

The comment may well be out of date, but the rusage structs contain
zero values for values which are non-zero in struct vmspace.

That was the reason for not using struct rusage to calculate values.

Regards,
Alistair