Re: CVS commit: src/sbin/disklabel

[David Laight <david%l8s.co.uk@localhost>]

On Tue, Jun 05, 2007 at 06:08:52PM -0500, David Young wrote:
> On Wed, Jun 06, 2007 at 08:22:34AM +1000, matthew green wrote:
> >    
> >    Modified Files:
> >     src/sbin/disklabel: main.c
> >    
> >    Log Message:
> >    Let the operator use the DISKLABELSECTOR and DISKLABELOFFSET
> >    environment variables to override the sector number, and the
> >    bytes-offset in the sector, where disklabel(8) writes a disklabel.
> > 
> > 
> > any particular reason these are env vars and not simply options
> > to disklabel?
> 
> Yes.  The variable names are mnemonic.  It is also easy to set a global
> default in a script.  I do not see any reason why there should not be
> command-line options, too, if you want to make it so.

For the host tool, I'd also have added a command option to specify the
port - and have disklebel know the corresponding default location.

        David

-- 
David Laight: david%l8s.co.uk@localhost