Re: CVS commit: src/etc

["Mike M. Volokhov" <mishka%netbsd.org@localhost>]

"Julio M. Merino Vidal" <jmmv84%gmail.com@localhost> wrote:
> On 05/06/2007, at 16:47, Juan RP wrote:
> 
> >On Tue, 5 Jun 2007 14:44:47 +0000
> >"Mike M. Volokhov" <mishka%netbsd.org@localhost> wrote:
> >
> >>Hmm... Thanks for this pointer.
> >>
> >>But is this really needed? The previous functionality was not
> >>complete, and I believe an updating can easy be done while running
> >>etcupdate, isn't it? Please note that lot of 'mainstream' variables
> >>have their own keywords, and setvar is mostly used for fine wscons
> >>tuning.
> >
> >IMHO it's needed. You broke previous configurations without mentioning
> >any of this in UPDATING or in a mailing list.
> >
> >Backward compatibility is always good.
> 
> This is a minor change and, as long as postinstall handles it, I  
> don't think it is such a big deal.  If you don't update properly the  
> system continues to boot/run just fine, only with minor annoyances.

Seconded once again.

Is the following patch appropriate then?

        M.


Index: UPDATING
===================================================================
RCS file: /cvsroot/src/UPDATING,v
retrieving revision 1.161
diff -u -r1.161 UPDATING
--- UPDATING    30 Apr 2007 20:50:20 -0000      1.161
+++ UPDATING    7 Jun 2007 08:12:20 -0000
@@ -32,6 +32,12 @@
        instead. See the GENERIC32_IP3x kernel configuration for an
        example.
 
+20070402:
+       The etc/rc.d/wscons and wscons.conf behavior was changed
+       for 'setvar' keyword.  Now it awaits three mandatory space
+       separated arguments on input: control device, variable
+       name, and value to set.  See wscons.conf(5) for details.
+
 20070319:
         src/lib/libc/Makefile revision 1.129 broke libc and ld.elf_so
         on many platforms due to incorrect flags settings.  If you
Index: share/man/man5/wscons.conf.5
===================================================================
RCS file: /cvsroot/src/share/man/man5/wscons.conf.5,v
retrieving revision 1.15
diff -u -r1.15 wscons.conf.5
--- share/man/man5/wscons.conf.5        12 Jan 2006 19:49:23 -0000      1.15
+++ share/man/man5/wscons.conf.5        7 Jun 2007 08:12:20 -0000
@@ -127,22 +127,16 @@
 .Xr wsconscfg 8
 for more information.
 .
-.It Sy setvar Ar part Ar var Ns = Ns Ar val
-Set wscons system driver variables by using
-.Xr wsconsctl 8 .
-The
-.Ar part
-argument is optional and can be used to indicate which portion of
-the device should be selected, this can be either
-.Dq keyboard ,
-.Dq display ,
-or
-.Dq mouse .
-If the argument is not specified then it defaults to
-.Dq keyboard
-to be backwards compatible with previous
-.Nx
-versions.
+.It Sy setvar Ar dev Ar var Ar val
+Set arbitrary wscons variable
+.Ar var
+to value
+.Ar val
+for specified control device
+.Ar dev .
+Can be used for direct modification of
+.Xr wscons 4
+variables, when no other keywords are suitable.
 See
 .Xr wsconsctl 8
 for more information.