Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/m68k/include



> > A cursory inspection showed that the specific _060 variants I
> > removed were no longer being used by any m68k code.  I didn't
> > check if the same was true for the _040 variants, although I
> > suspect it is.  Is there still a reason for keeping (or, in the
> > case of the _060, re-introduce) them?
>
> As I wrote, for consistency.
> _60 variants were exported as _40 ones before,
> so they should also be after the change.
> If you remove _60 variants, you should also remove
> _40 ones and rename all existing ops with _40 suffix.
> (i.e. no reason to leave only _40 variants exported)

OK, I've revert that part.

> Anyway, if you just intended to fix compile errors,
> why did you bother to backout unnecessary part
> without asking a person who made the original change?

Because after the removal of the references to the _60 macros, I
could not find any remaining code which used them, and they could
therefore easily be considered dead weight.  I'm sorry for having
overstepped a boundary, but sometimes such a boundary is
difficult to sense.

Regards,

- Håvard



Home | Main Index | Thread Index | Old Index