CVS commit: [netbsd-4] src/sys/dev

["Liam J. Foy" <liamjfoy%netbsd.org@localhost>]

Module Name:    src
Committed By:   liamjfoy
Date:           Fri Jun 15 11:00:23 UTC 2007

Modified Files:
        src/sys/dev [netbsd-4]: vnd.c

Log Message:
Pull up following revision(s) (requested by xtraeme in ticket #721):
        sys/dev/vnd.c: revisions 1.164 1.165
Fix compression problem from Cliff Wright:
Break one: because b_cylinder, and b_resid are one and the same.
The work the routine was commented as being its primary function,
end of patition adjustment, is wiped out, as at the end of
the routine b_cylinder is set, splat, doing a wipe out of the adjustment
to b_resid.
Break two: When doing the adjustment, a block count is created from a
byte count, a block calculation is done, then the results are compared to
the original byte count. i.e. apples to oranges, not blocks to blocks,
but blocks to bytes.
Break three: since if all the other drivers that used this routine
would have broken as vnd compress did, I must assume they always ignored
the results of this routine. So if end of patition adjustment is
really required then all these other drivers have been broken for a
long time.


To generate a diff of this commit:
cvs rdiff -r1.160 -r1.160.2.1 src/sys/dev/vnd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.