Re: CVS commit: src

[David Laight <david%l8s.co.uk@localhost>]

On Wed, Aug 15, 2007 at 09:24:20PM +0100, Andrew Doran wrote:
> Hi,
> 
> On Thu, Aug 16, 2007 at 01:44:26AM +0900, KIYOHARA Takashi wrote:
> 
> > From: David Young <dyoung%pobox.com@localhost>
> > Date: Tue, 14 Aug 2007 23:26:38 -0500
> > 
> > > On Wed, Aug 15, 2007 at 03:53:10AM +0000, KIYOHARA Takashi wrote:
> > > > Added Files:
> > > >         src/share/man/man3: gcq.3
> > > >         src/sys/sys: gcq.h
> > > 
> > > What is this?  Have you added entries to the set lists?
> > 
> > commited.
> > gcq is Generic Circular Queues.  Used by slhci.
> 
> I see where the original driver was proposed, but where was gcq proposed and
> how is it different from CIRCLEQ? It shouldn't go into the system without
> review and for now I think it should be backed out, or made part of the
> slhci driver's headers.

I remember something about it - and finding it was a double-linked list
through a dummy item (for the head).
I'm not sure it deserves quite so many (man page) entries, and certainly
isn't a replacement for any existing code.
In general linked list handling isn't that hard (tm) ...

        David

-- 
David Laight: david%l8s.co.uk@localhost