CVS commit: src/usr.bin/make

[David Laight <dsl%netbsd.org@localhost>]

Module Name:    src
Committed By:   dsl
Date:           Fri Oct 12 23:38:27 UTC 2007

Modified Files:
        src/usr.bin/make: parse.c

Log Message:
If we are going to save the names of all opened makefiles, do so when files
are first processed, not for every line of every loop inside the file.
When (attempting) to check for duplicate names, use the spaces between names
as separators rather than using strstr() - which is slow and wont find
duplicates after an incorect early match.
However the duplicate check is rather broken (especially for pkgsrc) where
names like ../../devel/atk/../../devel/glib2/../../devel/gettext-lib/ \
../../devel/gettext-lib/../../mk/buildlink3/../../mk/bsd.prefs.mk
which need (some form of) realpath() processing.
'cd pkgsrc/xaa/gtk2; make show-var VARNAME=.MAKE.MAKEFILES' shows the problem.


To generate a diff of this commit:
cvs rdiff -r1.138 -r1.139 src/usr.bin/make/parse.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.