Re: CVS commit: src/usr.bin/make

[Alan Barrett <apb%cequrux.com@localhost>]

On Sun, 14 Oct 2007, Simon Gerraty wrote:
> I was thinking though of shifting the custom entry to the end
> to avoid the need to redefine the others - would just look neater.

I thought of that too, but JobMatchShell() does a linear search and we
probably want it to find the custom shell in preference to one of the
predefined entries, so I think the custom entry has to be first.

> Also I was thinking of renaming _BASENAME_DEFSHELL to CUSTOM_DEFSHELL ?
> but DEFSHELL_NAME is fine.

I think I like DEFSHELL_CUSTOM better; it seems to fit nicely
with DEFSHELL_INDEX_CUSTOM.

--apb (Alan Barrett)