Re: CVS commit: src/sys/rump/librump

[Tom Spindler <dogcow%NetBSD.org@localhost>]

On Wed, Nov 07, 2007 at 06:59:19PM +0000, Antti Kantee wrote:
> 
> Module Name:  src
> Committed By: pooka
> Date:         Wed Nov  7 18:59:19 UTC 2007
> 
> Modified Files:
>       src/sys/rump/librump/rumpuser: rumpuser_pth.c
> 

This breaks horribly on 64-bit platforms, where "int" may not be what you
think it is. The casts here, there, and everywhere to (int) kinda worry me,
too.

/home/dogcow/work/nbsrc/sys/rump/librump/rumpuser/rumpuser_pth.c: In function 
'rumpuser_set_ipl':
/home/dogcow/work/nbsrc/sys/rump/librump/rumpuser/rumpuser_pth.c:286: warning: 
cast from pointer to integer of different size
/home/dogcow/work/nbsrc/sys/rump/librump/rumpuser/rumpuser_pth.c:287: warning: 
cast to pointer from integer of different size
/home/dogcow/work/nbsrc/sys/rump/librump/rumpuser/rumpuser_pth.c: In function 
'rumpuser_whatis_ipl':
/home/dogcow/work/nbsrc/sys/rump/librump/rumpuser/rumpuser_pth.c:295: warning: 
cast from pointer to integer of different size
/home/dogcow/work/nbsrc/sys/rump/librump/rumpuser/rumpuser_pth.c: In function 
'rumpuser_clear_ipl':
/home/dogcow/work/nbsrc/sys/rump/librump/rumpuser/rumpuser_pth.c:306: warning: 
cast from pointer to integer of different size
/home/dogcow/work/nbsrc/sys/rump/librump/rumpuser/rumpuser_pth.c:309: warning: 
cast to pointer from integer of different size


> Log Message:
> Execute I/O in a separate thread for async I/O where previously
> everything was written/read in caller context.
> 
> Also, make the "kernel" lock recursive.  It works better that way ...
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.5 -r1.6 src/sys/rump/librump/rumpkern/genfs_io.c
> cvs rdiff -r1.2 -r1.3 src/sys/rump/librump/rumpkern/ltsleep.c
> cvs rdiff -r1.20 -r1.21 src/sys/rump/librump/rumpkern/rump.c
> cvs rdiff -r1.12 -r1.13 src/sys/rump/librump/rumpkern/specfs.c
> cvs rdiff -r1.9 -r1.10 src/sys/rump/librump/rumpuser/rumpuser.h
> cvs rdiff -r1.2 -r1.3 src/sys/rump/librump/rumpuser/rumpuser_pth.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>