Re: CVS commit: src/sys/arch/i386/stand/genprom

[Alan Barrett <apb%cequrux.com@localhost>]

On Wed, 26 Dec 2007, Tom Spindler wrote:
> Modified Files:
>       src/sys/arch/i386/stand/genprom: genprom.c
> 
> Log Message:
> ding dong, the witch is __dead. Not sure why it was even bothered with here.

A log message should make sense without having to be viewed alongside
the diff, should explain what you changed, and explain why you changed
it.  In this case, I think you meant "Remove __dead marker from bail()
function beacsue __dead is not defined in my crosscompile environment."

Since bail() doesn't return, it seems to me that the __dead marker was
correct.  The proper fix is not to remove the __dead, but to change the
build so that __dead is defined.

--apb (Alan Barrett)