Re: CVS commit: src/sys/dev/pci

[David Young <dyoung%pobox.com@localhost>]

On Wed, Dec 26, 2007 at 05:17:33PM +0100, Joerg Sonnenberger wrote:
> On Wed, Dec 26, 2007 at 04:06:29AM +0000, David Young wrote:
> > Log Message:
> > Add device suspend/resume/detach.  (Tested with drvctl -S bnx0,
> > drvctl -Q bnx0, drvctl -d bnx0.)
> 
> Please merge bnx_stop and bnx_if_stop using the interface of the latter.
> The bnx_suspend_resume function shouldn't be needed either, as bnx_reset
> gets called from if_init with the same argument and bnx_stop supposedly
> handles the case for suspend already. If not, it should most likely do
> so for disable == 1.
> 
> Either bnx_detach (prefered) or bnx_stop need to deal with concurrent
> interrupts.

Done.

> Please add some static here as well.

If you feel strongly that bnx needs static, I won't stop you from
adding it.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933 ext 24