Re: CVS commit: src/lib/libc/string

[Jukka Salmi <j+nbsd%2008.salmi.ch@localhost>]

Alan Barrett --> source-changes (2008-02-22 22:13:42 +0200):
> On Fri, 22 Feb 2008, Alan Barrett wrote:
> > Also, I think the code will do the wrong thing in the case that char is
> > signed and the string contains characters with negative values; I think
> > it needs casts to (unsigned char) in a few places.
> 
> I see that later commits to the same files have fixed this issue.  Thanks.

Building strcspn.c rev. 1.13 fails:

#   compile  libc/strcspn.ln
CC=/a/tools/i386/bin/i386--netbsdelf-gcc /a/tools/i386/bin/i386--netbsdelf-lint 
-chapbxzFS -w -X 272 -d /a/dst/i386/usr/include  -D_LIBC -DLIBC_SCCS 
-DSYSLIBC_SCCS -D_REENTRANT -DHESIOD -DINET6 -DNLS -DYP 
-I/usr/src/lib/libc/include -I/usr/src/lib/libc -I/usr/src/sys 
-I/usr/src/lib/libc/compat/stdlib -I/usr/src/lib/libc/compat/../stdlib 
-I/usr/src/lib/libc/../../common/lib/libc/quad 
-I/usr/src/lib/libc/../../common/lib/libc/string 
-I/usr/src/lib/libc/../../common/lib/libc/arch/i386/string 
-D__DBINTERFACE_PRIVATE -DI18NMODULE_MAJOR=4 -DCITRUS 
-I/usr/src/libexec/ld.elf_so -I/usr/src/lib/libc/dlfcn 
-I/usr/src/lib/libc/gdtoa -DNO_FENV_H -I/usr/src/lib/libc/arch/i386/gdtoa 
-DCITRUS_ICONV -DWITH_RUNE -I/usr/src/lib/libc -DPOSIX_MISTAKE -DCOMPAT__RES 
-DUSE_POLL -DPORTMAP -DWIDE_DOUBLE -DALL_STATE -DUSG_COMPAT -D_FORTIFY_SOURCE=2 
   -i /usr/src/lib/libc/string/strcspn.c
/usr/src/lib/libc/string/strcspn.c(48): warning: bitwise operation on signed 
value possibly nonportable [117]
/usr/src/lib/libc/string/strcspn.c(52): warning: bitwise operation on signed 
value possibly nonportable [117]


Regards, Jukka

-- 
bashian roulette:
$ ((RANDOM%6)) || rm -rf ~