Re: CVS commit: src/sys/compat/irix

[Antti Kantee <pooka%cs.hut.fi@localhost>]

On Fri Mar 07 2008 at 00:03:40 +0000, Tobias Nygren wrote:
> 
> Module Name:  src
> Committed By: tnn
> Date:         Fri Mar  7 00:03:40 UTC 2008
> 
> Modified Files:
>       src/sys/compat/irix: irix_usema.c
> 
> Log Message:
> v_interlock is a kmutex_t now, simple_lock() -> mutex_enter().

Two things spring to mind:
1) why is it using simple_lock like that?
2) does this change fix an actual problem and did you test it?

I'm not saying the original was correct, but if it worked due to
simple_locks being null ops most of the time ...

-- 
Antti Kantee <pooka%iki.fi@localhost>                     Of course he runs 
NetBSD
http://www.iki.fi/pooka/                          http://www.NetBSD.org/
    "la qualité la plus indispensable du cuisinier est l'exactitude"