Re: CVS commit: src/sys/lib/libsa

[David Laight <david%l8s.co.uk@localhost>]

On Mon, Mar 17, 2008 at 12:41:41PM +0200, Alan Barrett wrote:
> On Sat, 15 Mar 2008, David Laight wrote:
> > > > src/sys/lib/libsa: dosfs.c
> > > >Log Message:
> > > >Add a local strcasecmp() instead of pulling the bloat from libkern.
> > > can't we use reachover to common/lib/libc/string?
> > That is where libkern gets it from, and is the function I'm trying
> > to avoid!
> 
> Is there an easy way of saying
> 
>       #if optimise_for_space
>               use this implementation
>       #else
>               use another implementation
>       #endif
> 
> ?
> 
> If so, then various is*() and to*() functions could switch between using
> fast implementations with lookup tables, or small implementations with
> conditional tests.

This is orthogonal to the changes I was making.
The tolower() code that gets compiled into libkern.a is already using
a range test, not a lookup table.
However I was actually chasing a small number of bytes in order to get
some free space in bootxx_msdos.
I was also considering removing libkern from the bootxx builds completely.

        David

-- 
David Laight: david%l8s.co.uk@localhost