Re: CVS commit: src/sys/kern

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

> On Tue, 1 Apr 2008 23:16:06 +0100
> Andrew Doran <ad%netbsd.org@localhost> wrote:
> 
> > The original code (1.125) was correct - I don't understand why it needed
> > changing
> 
> True. rmind@ has confused me... we are now back to the original behaviour.

then can you please revert the changes?

> The problem originates in a uvm_fault in fill_lwp() and this pointed to the
> strncpy() for l_wmesg. I've sent this to current-users@ but no idea why
> it didn't arrive.
> 
> #16 0xc07644a0 in strncpy (dst=0xccb2ebc0 "wait", src=0xccb7c680
> <Address 0xccb7c680 out of bounds>, n=8)
>     at /usr/src/sys/lib/libkern/../../../common/lib/libc/string/strncpy.c:66
> #17 0xc041d5b3 in fill_lwp (l=0xccbd4960, kl=0xccb2eb80) at
> /usr/src/sys/kern/init_sysctl.c:3078
> #18 0xc041fea6 in sysctl_kern_lwp (name=0xccb2eca4, namelen=3,
> oldp=0xbb929000, oldlenp=0xccb2eccc, newp=0x0, newlen=0, 
> oname=0xccb2ec9c, l=0xccbd4b80, rnode=0xc1e69500) at 
> /usr/src/sys/sys/lwp.h:326
> #19 0xc044d40f in sysctl_dispatch (name=0xccb2ec9c, namelen=3,
> oldp=0xbb929000, oldlenp=0xccb2eccc, newp=0x0, newlen=0, 
> oname=0xccb2ec9c, l=0xccbd4b80, rnode=0xc1e69500) at
> /usr/src/sys/kern/kern_sysctl.c:446
> #20 0xc044d6e6 in sys___sysctl (l=0xccbd4b80, uap=0xccb2ed00,
> retval=0xccb2ed28) at /usr/src/sys/kern/kern_sysctl.c:302
> #21 0xc0519685 in syscall (frame=0xccb2ed48) at
> /usr/src/sys/arch/i386/i386/syscall.c:112
> #22 0xc0100574 in syscall1 ()
> (gdb)
> 
> How can this happen? and sorry for the inconvenience... I shouldn't do
> proxy-commits without looking at it more carefully.

please file a PR.

YAMAMOTO Takashi

> -- 
> Juan Romero Pardines - xtraeme at gmail|netbsd dot org
>       The NetBSD Project
> 
> Make your own NetBSD/x86 Live CD:
> http://www.netbsd.org/~xtraeme/mklivecd/