Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: uvm ncolors [was: CVS commit: src/sys/arch/x86/x86]



Thor Lancelot Simon wrote:

> On Tue, Apr 22, 2008 at 08:40:48AM +0100, Alistair Crooks wrote:
>
> > PS. Is the check for newncolors being a power of two necessary any more?
> 
> I think so, yes.  If there's any other way a non-power-of-two value
> could get in there, you want it fixed up.

I think Al's point is that if "1 << N" returns a non-power-of-two then
there are bigger problems than just the number of colours that UVM knows
about...

Cheers,
Simon.


Home | Main Index | Thread Index | Old Index