Re: CVS commit: src/common/lib/libprop

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

> Module Name:  src
> Committed By: xtraeme
> Date:         Tue May  6 13:52:51 UTC 2008
> 
> Modified Files:
>       src/common/lib/libprop: prop_array.c prop_dictionary.c
>           prop_object_impl.h
> 
> Log Message:
> Do not acquire the rwlock recursively in 
> prop_{array,dictionary}_iterator_reset()
> when prop_{array,dictionary}_copyout_ioctl() is called.
> 
> Introduce _PROP_RWLOCK_OWNED() which is a KASSERT(rw_lock_held(lock))
> and use it in those two functions, also acquire the rwlock in other
> places where it is required now.

can you make it consistent with the rest of code?
eg. _PROP_ASSERT(_PROP_RWLOCK_HELD(lock))

YAMAMOTO Takashi

> 
> This fixes a LOCKDEBUG panic "locking against myself", as reported by
> Geoff C. Wing in current-users@.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.12 -r1.13 src/common/lib/libprop/prop_array.c
> cvs rdiff -r1.24 -r1.25 src/common/lib/libprop/prop_dictionary.c
> cvs rdiff -r1.20 -r1.21 src/common/lib/libprop/prop_object_impl.h
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.