Re: CVS commit: src/sys/arch/x86/include

[David Young <dyoung%pobox.com@localhost>]

On Fri, May 09, 2008 at 11:05:47PM +0100, Andrew Doran wrote:
> On Fri, May 09, 2008 at 09:53:56PM +0000, Christoph Egger wrote:
> > 
> > Module Name:        src
> > Committed By:       cegger
> > Date:               Fri May  9 21:53:56 UTC 2008
> > 
> > Modified Files:
> >     src/sys/arch/x86/include: i82489reg.h
> > 
> > Log Message:
> > Buildfix: Remove duplicate #defines.
> 
> @@ -108,8 +108,6 @@
>  
>  
>  #define LAPIC_ICRHI    0x310                   /* Int. cmd. RW */
> -#      define LAPIC_ID_MASK            0x0f000000
> -#      define LAPIC_ID_SHIFT           24
>  
> 
> Where else in the source tree do you see those?

FWIW, you can produce these definitions quickly like so,

#define LAPIC_ID_MASK   __BITS(27,24)

Later, you can quickly verify them against the datasheet. :-)

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933 ext 24