Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/dist/nvi/common



Aymeric Vincent <vincent%labri.fr@localhost> writes:

>> -        sp->gp->special_key[(UCHAR_T)ch] :                          \
>> +        sp->gp->special_key[(unsigned char)ch] :                    \
>
> I don't see how it fixes a bug: this cast is done only if (ch <= 255),

Ignore my previous e-mail: sure, the cast to an unsigned integer
bigger than unsigned char is buggy if ch is a signed char.

I'll think more about all this during the day.

 Aymeric


Home | Main Index | Thread Index | Old Index