Re: CVS commit: src/dist/nvi/common

[Aymeric Vincent <vincent%labri.fr@localhost>]

christos%zoulas.com@localhost (Christos Zoulas) writes:

> On Jun 12, 11:20pm, vincent%labri.fr@localhost (Aymeric Vincent) wrote:
> -- Subject: Re: CVS commit: src/dist/nvi/common
>
> | > -     sp->gp->special_key[(UCHAR_T)ch] :                          \
> | > +     sp->gp->special_key[(unsigned char)ch] :                    \
> | 
> | I don't see how it fixes a bug: this cast is done only if (ch <= 255),
> | so whatever the signedness of ch, and whatever the actual size of
> | UCHAR_T, we will get a value comprised between 0 and 255, and of an
> | unsigned integer type.
>
> It is a bug; a character containing 255 is negative. What do you think this
> prints?

Sure, I was wrong. Sorry.

 Aymeric