Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/dist/nvi/common



On Jun 13, 11:14am, vincent%labri.fr@localhost (Aymeric Vincent) wrote:
-- Subject: Re: CVS commit: src/dist/nvi/common

| I applied your patch and tried to cross compile a macppc nvi, and the
| warning is still there: gcc seems to use the interval of the type of
| (ch) and not of the (UCHAR_T) type to decide if the comparison is
| always true, which from an optimization point of view is OK.
| 
| Your patch doesn't touch the litigious comparison in the USE_WIDECHAR
| case, which is NetBSD's case.

Hmm, that sounds like a gcc bug. I have an arm box and I will test.


| How about setting MAX_FAST_KEY to 127 until we think of a better fix?
| ;-)

Sure, let's do that. Commit the patch and set it to 127.

christos


Home | Main Index | Thread Index | Old Index