Re: CVS commit: src/sys/fs/udf

[Simon Burge <simonb%NetBSD.org@localhost>]

Daniel Carosone wrote:

> On Sat, Jul 19, 2008 at 04:36:40PM +0000, Reinoud Zandijk wrote:
> > 
> > Module Name:        src
> > Committed By:       reinoud
> > Date:               Sat Jul 19 16:36:40 UTC 2008
> > 
> > Modified Files:
> >     src/sys/fs/udf: udf_vfsops.c
> > 
> > Log Message:
> > Limit sectorsize to max. 4096 bytes. This prevents a panic when declaring
> > the node pool since standard pools are limited upto 4096 aparently.
> > Pagesize limit even?
> 
> Yes, page size.

Further to that, it's just the default allocator that uses the page
based allocator.  Look at the palloc argument to pool_init() in pool(9)
if you want/need to use a different allocator that has different
constraints.

Two other questions/comments:

 - What's the correlation between sector size and node sizes?  The
   pool_init() call uses sizeof(struct udf_node) which in no way
   seems dependent on the sector size so I'm not sure I understand
   what panic this fixes.

 - The original commit message says "limit to 4096" but the code
   says ">= 8192".

Cheers,
Simon.