Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/usr.sbin/postinstall



Module Name:    src
Committed By:   apb
Date:           Sun Sep  7 12:34:06 UTC 2008

Modified Files:
        src/usr.sbin/postinstall: postinstall

Log Message:
Cleanup shell quoting:

* Almost all shell variables are now quoted, except where they
  hold numeric values such as exit status, or where we want
  the shell to split on spaces.

* Constructs like

    _files="$@"
    do_something_with $files

  are changed to

    #_files="$@"
    do_something_with "$@"

* In contexts where we do actually want the args to be concatenated with
  space separators, use "$*", not "$@".

Tested by running "postinstall check" with a SCRATCHDIR whose name
contained spaces.


To generate a diff of this commit:
cvs rdiff -r1.65 -r1.66 src/usr.sbin/postinstall/postinstall

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



Home | Main Index | Thread Index | Old Index