Re: CVS commit: src/sys/ufs/ffs

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Mon, Sep 08, 2008 at 10:06:13AM +0200, Alan Barrett wrote:
> On Mon, 08 Sep 2008, Joerg Sonnenberger wrote:
> > Log Message:
> > Move successful removal of unreferenced inodes under WAPBL_DEBUG to not
> > spam the console.
> 
> I think that such messages are the moral equivalent of what fsck would
> print with a non-wapbl file system, so I'd prefer them not to be
> completely hidden by default.

The fsck messages don't spam dmesg though. I wouldn't mind them to be on
debug level, but I don't think they provide real value.

> I suggest a compromise of a single summary message with
> a count of removed inodes.

That would be fine with me.

> Also, WAPBL_DEBUG seems to be undocumented.  It's not in options(4), and
> it's not present as a commented-out option in src/sys/arch/*/conf/*.

I asked Simon what to conditionalize it on a while ago and that's what
he suggested.

Joerg