Re: CVS commit: src/sys/sys

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

Bill Stouder-Studenmund wrote:
> On Wed, Oct 15, 2008 at 11:03:30PM +0200, Christoph Egger wrote:
>> Bill Stouder-Studenmund wrote:
>>> Module Name:        src
>>> Committed By:       wrstuden
>>> Date:               Wed Oct 15 20:32:46 UTC 2008
>>>
>>> Modified Files:
>>>     src/sys/sys: lwp.h
>>>
>>> Log Message:
>>> Pre-declare struct sadata_vp here so we avoid a circular dependency
>>> between this file and savar.h. This lets lwp.h stand on its own.
>>>
>>> I do not understand why compiling kernels on i386 did not catch this.
>> This doesn't fix anything. i386 doesn't catch this, because a pointer
>> size is known. arm still doesn't build because it dereferences sadata_vp.
>> For dereferencing the compiler has to know the struct definition.
> 
> On icb, you reported a circular dependency, which this will fix.
> 
> In investigating this, I've found that a lot of stuff pre-defines struct 
> lwp, so savar.h probably needs to too. The reason i386 wasn't affected 
> most likely is that the file you had problems with didn't include one of 
> the header files that pre-defines struct lwp.
> 
> Sadly, the file you're having problems with scrolled off my history.  
> Please remind me which one it is. The solutions probably are to add struct
> lwp to savar.h and to add an include of it to whichever file you're having
> issues with.

You can reproduce when you try to make an arm port compile again such as
acorn32 or zaurus.

Christoph