Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/rump/fs/lib/libnfs



On Thu, Oct 16, 2008 at 07:27:09PM +0000, Christos Zoulas wrote:

I know there is a longer thread, but...

> -     struct vm_page *pgs[npages];
> +     struct vm_page *pgs;

Surely you meant: struct vm_page **pgs;

Also is is very likely that npages will be small? (say 4 or less?)
In which case using a fixed size on-stack buffer fo the small
case is probably worth while.

        David

-- 
David Laight: david%l8s.co.uk@localhost


Home | Main Index | Thread Index | Old Index