Re: CVS commit: src/sys/dev/pci

[Bernd Ernesti <veego%NetBSD.org@localhost>]

On Fri, Oct 31, 2008 at 11:53:11AM +1300, Darran Hunt wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi Bernd,
> 
> The NetOctave NSP2000 is a crypto-acceleration card that accelerates  
> RNG, Public Key (D-H, RSA, DSA), SSL, TLS,  and IPSec.  The driver is  
> integrated with the opencrypto framework to provide hardware offload  
> for the following operations:

Ok, thank you for that explanation.

[..]
> The driver functions fine without the entry in pcidevs, but thank you  
> for bringing that to my attention.  Are the pcidevs.h and  
> pcidevs_data.h headers critical to the driver system?  I didn't think  
> so, but I can update pcidevs if it is required.  Tools such as lcpci  
> obtain their information from the usual pci.ids file, which does have  
> an entry for NetOctave.

Entries for new drivers should be added to pcidevs.
lspci is not in the NetBSD base system, which has different tools which
uses pcidevs.

> The term "n8" comes from NetOctave, a reduction of "Net" and "Oct" to  
> "N" & "8".

It would have been better if there was some public review before, like
tech-kern where concerns could have been addressed.

I'm not too happy with the n8 obfuscation.

Btw, it is usually the case to mention who reviewed a change if you do
your first commits.

Regards,
Bernd