Re: CVS commit: src/usr.bin/make

[Hisashi T Fujinaka <htodd%twofifty.com@localhost>]

On Sun, 30 Nov 2008, Hisashi T Fujinaka wrote:

> On Mon, 1 Dec 2008, Michael wrote:
>
> > Hello,
> >
> > On Nov 30, 2008, at 5:37 PM, David Laight wrote:
> >
> > > Module Name:    src
> > > Committed By:   dsl
> > > Date:           Sun Nov 30 22:37:55 UTC 2008
> > >
> > > Modified Files:
> > >         src/usr.bin/make: for.c
> > >
> > > Log Message:
> > > Simplify somewhat the code that parses .for lines.
> > > Use malloc to allocate space for teh strings (instead of a buf structure)
> > > to make it mossible to not leak the associated memory (leak not fixed!).
> > > No functional change intended.
> > >
> > >
> > > To generate a diff of this commit:
> > > cvs rdiff -r1.32 -r1.33 src/usr.bin/make/for.c
> >
> > This borks nbmake on both sparc64 (SIGBUS) and macppc (SIGSEGV).
> > Please revert it.
>
> Is this what breaks build.sh on i386?
>
> cc  -O -DDEFSHELL_CUSTOM="/bin/sh" -DHAVE_SETENV=1 -DHAVE_STRDUP=1 
> -DHAVE_STRERROR=1 -DHAVE_STRFTIME=1 -DHAVE_VSNPRINTF=1  -c  
> /usr/src/tools/make/../../usr.bin/make/lst.lib/lstSucc.c
> cc  -O -o nbmake *.o [1]   Segmentation fault (core dumped) 
> /tmp/nbbuild6828...
> nbmake: "/usr/src/share/mk/bsd.own.mk" line 95: warning: "cd /usr/src && 
> /tmp/nbbuild6828/nbmake -V .OBJDIR" returned non-zero status
> [1]   Segmentation fault (core dumped) "${make}" -m ${T...
>
> ERROR: raw_getmakevar TOOLCHAIN_MISSING: /tmp/nbbuild6828/nbmake failed
> *** BUILD ABORTED ***
> Exit 1

I reverted locally and it was what broke builds on i386.

--
Hisashi T Fujinaka - htodd%twofifty.com@localhost
BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte