Re: CVS commit: src

["Takehiko NOZAKI" <takehiko.nozaki%gmail.com@localhost>]

hi,

> I've been able to make it work with the following patch:

ok thanks, please commit it.
(i think it's better add `ifdef HAVE_NBTOOL_CONFIG_H' directly
src/lib/libc/stdio/fparseln.c)

but one question, MacOS X have thier own fparseln(3):
http://developer.apple.com/documentation/Darwin/Reference/ManPages/man3/fparseln.3.html

it seems that some #ifdef needed for FPARSELN_UNESCALL
(in NetBSD, #define _NETBSD_SOURCE is required)
or these flags constant defined in util.h, right?

anyway, configure script doesn't know about it, so treated as BROKEN_FPARSELN.
i have to reconsider fparseln checking...

> But still, with this patch, I get the following warning during link time.
> The cross-mklocale tool still seems to work, though.
>
> ---- cut here ----
>       link  mklocale/mklocale
> /usr/libexec/gcc/i686-apple-darwin8/4.0.1/ld: warning multiple definitions of 
> symbol ___fix_locale_grouping_str
> fix_grouping.lo definition of ___fix_locale_grouping_str in section 
> (__TEXT,__text)
> /usr/lib/gcc/i686-apple-darwin8/4.0.1/../../../libSystem.dylib(fix_grouping.So)
>  definition of ___fix_locale_grouping_str
> ---- cut here ----

this function derived from FreeBSD(also MacOS X has it), so conflict
with their libc's symbol.
the solution is renaming our __fix_locale_grouping_str to
__nb_fix_locale_grouping_str.
i'll fix it.


very truly yours.
-- 
Takehiko NOZAKI<takehiko.nozaki%gmail.com@localhost>