Re: CVS commit: src/sys/miscfs/genfs

[Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>]

yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) wrote:
> > Module Name:        src
> > Committed By:       rmind
> > Date:               Wed Feb  4 20:32:19 UTC 2009
> > 
> > Modified Files:
> >     src/sys/miscfs/genfs: genfs_io.c
> > 
> > Log Message:
> > genfs_getpages: move putiobuf() and uvm_pagermapout() outside the glock.
> > OK by <ad>.
> > 
> > 
> > To generate a diff of this commit:
> > cvs rdiff -r1.17 -r1.18 src/sys/miscfs/genfs/genfs_io.c
> > 
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> 
> why?

These operations (free and unmap) do not require glock. Why would you want
to keep the operations, which might potentially block, under the lock?

> 
> YAMAMOTO Takashi

-- 
Best regards,
Mindaugas