CVS commit: src/usr.bin/make

["Simon J. Gerraty" <sjg%netbsd.org@localhost>]

Module Name:    src
Committed By:   sjg
Date:           Tue May  5 21:51:09 UTC 2015

Modified Files:
        src/usr.bin/make: cond.c nonints.h var.c
        src/usr.bin/make/unit-tests: Makefile
Added Files:
        src/usr.bin/make/unit-tests: cond2.exp cond2.mk

Log Message:
When evaluating condtionals from .if we want to require
that the lhs is a variable reference, a number or a quoted string.
This helps avoid subtle bugs caused by typos.

When conditionals are being evaluated during variable expansion
we cannot be as strict becuase lhs will already have been expanded.

We therefor pass a boolean to Cond_EvalExpression to tell it how
lhs should be treated.

Add unit-tests/cond2.mk to test the above

Reviewed by: christos, joerg


To generate a diff of this commit:
cvs rdiff -u -r1.67 -r1.68 src/usr.bin/make/cond.c src/usr.bin/make/nonints.h
cvs rdiff -u -r1.191 -r1.192 src/usr.bin/make/var.c
cvs rdiff -u -r1.51 -r1.52 src/usr.bin/make/unit-tests/Makefile
cvs rdiff -u -r0 -r1.1 src/usr.bin/make/unit-tests/cond2.exp \
    src/usr.bin/make/unit-tests/cond2.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.