Source-Changes archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
CVS commit: src/lib/libedit
Module Name: src
Committed By: christos
Date: Tue Apr 12 00:16:06 UTC 2016
Modified Files:
src/lib/libedit: keymacro.c keymacro.h map.c read.c
Log Message:
>From Ingo Schwarze:
* Delete the stubs of the XK_EXE mechanism that was never implemented.
From a security, stability, and simplicity perspective, i would
consider implementing it a truly terrible idea, so let's better
get rid of it.
* Do not use the local variable "num" in el_wgets() alternately for
two completely different purposes. Only use it for the number
of characters read, as stated in the comment (or -1 as long as
that number is still unknown), not for the (more or less boolean)
return value of read_getcmd(). Actually, there is no need at
all to save the latter return value after testing it once.
* The function read_getcmd() has very unusual return values:
It returns -1 for success and 0 for EOF/error. Switch that around
to 0 for success and -1 for EOF/error to be less confusing, and
get rid of the OKCMD preprocessor macro.
* Get rid of one #ifdef section in el_wgets() by using
el->el_chared.c_macro directly at the only place
where it is used.
* Delete the unused MIN() macro.
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/lib/libedit/keymacro.c
cvs rdiff -u -r1.4 -r1.5 src/lib/libedit/keymacro.h
cvs rdiff -u -r1.47 -r1.48 src/lib/libedit/map.c
cvs rdiff -u -r1.91 -r1.92 src/lib/libedit/read.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Home |
Main Index |
Thread Index |
Old Index