CVS commit: [netbsd-6] src

["Soren Jacobsen" <snj%netbsd.org@localhost>]

Module Name:    src
Committed By:   snj
Date:           Sun Nov  5 20:04:34 UTC 2017

Modified Files:
        src/dist/nvi/common [netbsd-6]: recover.c
        src/usr.bin/nvi/recover [netbsd-6]: virecover

Log Message:
Pull up following revision(s) (requested by spz in ticket #1509):
        external/bsd/nvi/usr.bin/recover/virecover: 1.2-1.3 via patch
        external/bsd/nvi/dist/common/recover.c: revision 1.6-1.9 via patch
be more careful about opening recovery files... in particular deal with
people trying to get 'vi -r' stuck using named pipes, symlink attacks,
and coercing others opening recovery files they did not create.
Put back the tests for "no files matched" (in a different way than they
were written previously - but that's just style.)   This is not csh...
Use the correct test operator to test for an empty file (rather than
testing for an empty file name...)
Write test ('[') commands in a way that is defined to work, rather than
just happens to - we can afford the (negligible) performance hit here.
- don't use command substitution to glob a pattern into a list of filenames;
  it is less efficient than doing it directly and does not handle whitespace
  in filenames properly.
- change test to [
- quote variables
Deal safely with recovery mail files.
oops, accidendally committed an earlier non-working version; fixed.
Don't use popenve() for portability; forking an extra shell here is not an
issue.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.3.10.1 src/dist/nvi/common/recover.c
cvs rdiff -u -r1.1 -r1.1.22.1 src/usr.bin/nvi/recover/virecover

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.