CVS commit: src/sys

["Ryota Ozaki" <ozaki-r%netbsd.org@localhost>]

Module Name:    src
Committed By:   ozaki-r
Date:           Fri Dec  8 05:22:23 UTC 2017

Modified Files:
        src/sys/dev/pci: if_wm.c
        src/sys/net: if.c if.h

Log Message:
Revert "Make if_timer MP-safe if IFEF_MPSAFE"

Because it has decreased the performance of wm. And also I found that
wm_watchdog doesn't work well with if_watchdog framework at all. Sharing one
counter (if_timer) with multiple instances (hardware multi-queues) can't detect
a single (or some) stall of them because other instances reset the counter even
if the stalled one want the watchdog to fire.

Interfaces without IFEF_MPSAFE works safely with the original if_watchdog thanks
to KENREL_LOCK. OTOH, interfaces with IFEF_MPSAFE shouldn't use if_watchdog and
should implement their own watchdog timer that works with multiple instances.


To generate a diff of this commit:
cvs rdiff -u -r1.548 -r1.549 src/sys/dev/pci/if_wm.c
cvs rdiff -u -r1.410 -r1.411 src/sys/net/if.c
cvs rdiff -u -r1.250 -r1.251 src/sys/net/if.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.