CVS commit: src/usr.bin/make

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    src
Committed By:   rillig
Date:           Sat Aug 22 11:35:00 UTC 2020

Modified Files:
        src/usr.bin/make: arch.c compat.c dir.c job.c main.c make.c parse.c
            suff.c targ.c

Log Message:
make(1): replace "(void)Lst_AtEnd" with stricter "Lst_AppendS"

This change ensures that there is actually something added to the list.
Lst_AtEnd had silently skipped the addition if the list was invalid
(null pointer), which was not intended in these cases.  The "(void)" is
assumed to mean "I know that this cannot fail", while it could also mean
"I don't care whether something actually happened".

Running "./build.sh -j6 tools" still succeeds after this change,
therefore chances are very low that this change breaks anything.  If
there is any change, it's an obvious assertion failure.  There is no
silent change in behavior though.


To generate a diff of this commit:
cvs rdiff -u -r1.86 -r1.87 src/usr.bin/make/arch.c
cvs rdiff -u -r1.121 -r1.122 src/usr.bin/make/compat.c
cvs rdiff -u -r1.99 -r1.100 src/usr.bin/make/dir.c
cvs rdiff -u -r1.209 -r1.210 src/usr.bin/make/job.c
cvs rdiff -u -r1.306 -r1.307 src/usr.bin/make/main.c
cvs rdiff -u -r1.109 -r1.110 src/usr.bin/make/make.c
cvs rdiff -u -r1.252 -r1.253 src/usr.bin/make/parse.c
cvs rdiff -u -r1.101 -r1.102 src/usr.bin/make/suff.c
cvs rdiff -u -r1.67 -r1.68 src/usr.bin/make/targ.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.