CVS commit: src/usr.bin/make

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    src
Committed By:   rillig
Date:           Sat Aug 22 22:41:42 UTC 2020

Modified Files:
        src/usr.bin/make: lst.c lst.h make.c parse.c suff.c

Log Message:
make(1): make moving and copying lists simpler

Instead of the two-in-one Lst_Concat, having two separate functions is
easier to understand.  There is no need for a long API comment anymore
since the new functions have a single purpose that is accurately
described by their name.

The long comment inside Lst_Concat has been removed since it only
repeated the exact code, only in more words.

The comments in make.c about appending the cohorts had been wrong.  They
were not appended but prepended.  Once more, the function name expresses
everything that the comment said, making the comment redundant.  There
is no need to test whether the cohorts list is empty, doing nothing is
implied by the word All in Lst_PrependAllS.


To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/usr.bin/make/lst.c
cvs rdiff -u -r1.36 -r1.37 src/usr.bin/make/lst.h
cvs rdiff -u -r1.119 -r1.120 src/usr.bin/make/make.c
cvs rdiff -u -r1.260 -r1.261 src/usr.bin/make/parse.c
cvs rdiff -u -r1.110 -r1.111 src/usr.bin/make/suff.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.